Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko: Make sure localized links are used rather than /en-US/* (part 4) #14259

Merged
merged 4 commits into from
Jul 30, 2023
Merged

ko: Make sure localized links are used rather than /en-US/* (part 4) #14259

merged 4 commits into from
Jul 30, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR fixes all of the links within the Korean locale so that they no longer point to English content. This is part 4 of 4.

Additionally, this PR performs a few additional formatting changes around related lines to fix formatting errors.

@queengooborg queengooborg requested a review from a team as a code owner July 15, 2023 12:43
@queengooborg queengooborg requested review from swimjiy and removed request for a team July 15, 2023 12:43
@queengooborg queengooborg mentioned this pull request Jul 15, 2023
Closed
16 tasks
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023 •
edited
Loading

Preview URLs (45 pages)
Flaws (374)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/Progressive_web_apps
Title: 프로그레시브 웹 앱
Flaw count: 10

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 5 more flaws omitted

URL: /ko/docs/Web/XSLT
Title: XSLT
Flaw count: 4

  • broken_links:
    • Can't resolve /ko/XML
    • Can't resolve /ko/HTML
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/JavaScript/Reference/Statements/function*
Title: function*
Flaw count: 3

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Functions_and_function_scope does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Functions
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://

URL: /ko/docs/Web/JavaScript/Reference/Statements/for-await...of
Title: for await...of
Flaw count: 2

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/asyncIterator does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/asyncIterator
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ko/docs/Web/JavaScript/Reference/Statements/while
Title: while
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ko/docs/Web/JavaScript/Reference/Statements/var
Title: var
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/JavaScript/Reference/Statements/return
Title: return
Flaw count: 3

  • broken_links:
    • Anchor not lowercase
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Closures
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Closures

URL: /ko/docs/Web/JavaScript/Reference/Statements/for...in
Title: for...in
Flaw count: 2

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Iterators_and_Generators

URL: /ko/docs/Web/JavaScript/Reference/Statements/if...else
Title: if...else
Flaw count: 2

  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Expressions_and_Operators#표현식
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

URL: /ko/docs/Web/JavaScript/Reference/Statements/label
Title: label
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ko/docs/Web/JavaScript/Reference/Statements/switch
Title: switch
Flaw count: 4

  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Expressions_and_Operators
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/JavaScript/Reference/Statements/with
Title: with
Flaw count: 6

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Array/prototype does not exist
    • /ko/docs/Web/JavaScript/Reference/Array/prototype does not exist
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/unscopables does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/unscopables
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/unscopables does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/unscopables
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/JavaScript/Reference/Operators
Title: 식 및 연산자
Flaw count: 22

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Operators/Logical_NOT does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/Logical_NOT
    • /ko/docs/Web/JavaScript/Reference/Operators/Less_than does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/Less_than
    • /ko/docs/Web/JavaScript/Reference/Operators/Greater_than does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/Greater_than
    • /ko/docs/Web/JavaScript/Reference/Operators/Less_than_or_equal does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/Less_than_or_equal
    • /ko/docs/Web/JavaScript/Reference/Operators/Greater_than_or_equal does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/Greater_than_or_equal
    • and 14 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Glossary/nullish
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/null
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/연산자_우선순위

URL: /ko/docs/Web/JavaScript/Reference/Operators/function*
Title: function* expression
Flaw count: 3

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Functions_and_function_scope does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Functions
  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/JavaScript/Reference/Operators/Optional_chaining
Title: Optional chaining
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /ko/docs/Web/JavaScript/Reference/Operators/Nullish_Coalescing_Operator redirects to /ko/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Property_Accessors#bracket_notation
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/JavaScript/Reference/Operators/yield
Title: yield
Flaw count: 3

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ko/docs/Web/JavaScript/Reference/Operators/Equality
Title: 동등 연산자(==)
Flaw count: 4

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/JavaScript/Reference/Operators/in
Title: in 연산자
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ko/docs/Web/JavaScript/Reference/Operators/yield*
Title: yield*
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/JavaScript/Reference/Operators/new
Title: new operator
Flaw count: 3

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/Function/prototype
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/Function/prototype

URL: /ko/docs/Web/JavaScript/Reference/Operators/delete
Title: delete 연산자
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Web/JavaScript/Memory_Management

URL: /ko/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Title: 구조 분해 할당
Flaw count: 3

  • broken_links:
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/JavaScript/Reference/Operators/function
Title: 함수 표현식
Flaw count: 5

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Arrow_functions does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions
    • /ko/docs/Web/JavaScript/Reference/Functions_and_function_scope does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Functions
  • broken_links:
    • Can't resolve /ko/docs/
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing
Title: Nullish coalescing operator
Flaw count: 9

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/null
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Operator_Precedence
    • and 3 more flaws omitted

URL: /ko/docs/Web/JavaScript/Reference/Strict_mode
Title: Strict mode
Flaw count: 15

  • macros:
    • /ko/docs/Web/API/WindowTimers/setTimeout redirects to /ko/docs/Web/API/setTimeout
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Strict_mode/Transitioning_to_strict_mode
    • Is currently http:// but can become https://
    • and 9 more flaws omitted

URL: /ko/docs/Web/JavaScript/Reference/Template_literals
Title: Template literals
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /ko/docs/Web/Manifest
Title: Web app manifests
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/HTML/CORS_settings_attributes does not exist
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /ko/docs/Web/XPath
Title: XPath
Flaw count: 10

  • broken_links:
    • Can't resolve /ko/XML
    • Can't resolve /ko/XSLT
    • Can't resolve /ko/DOM/document.getElementById
    • Can't resolve /ko/DOM/element.childNodes
    • Can't resolve /ko/XUL
    • and 5 more flaws omitted

URL: /ko/docs/Web/Media/Formats/codecs_parameter
Title: 일반 미디어 타입에서 "codecs" 파라미터 사용하기
Flaw count: 26

  • macros:
    • /ko/docs/Glossary/MIME does not exist but fell back to /en-US/docs/Glossary/MIME
    • /ko/docs/Glossary/SMPTE does not exist but fell back to /en-US/docs/Glossary/SMPTE
    • /ko/docs/Web/HTML/Element/source does not exist but fell back to /en-US/docs/Web/HTML/Element/source
    • /ko/docs/Web/API/MediaSource/isTypeSupported does not exist but fell back to /en-US/docs/Web/API/MediaSource/isTypeSupported_static
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 17 more flaws omitted

URL: /ko/docs/Web/Media/Formats/Video_codecs
Title: 웹 비디오 코덱 가이드
Flaw count: 57

  • macros:
    • /ko/docs/Glossary/RTP does not exist but fell back to /en-US/docs/Glossary/RTP
    • /ko/docs/Glossary/RTP does not exist but fell back to /en-US/docs/Glossary/RTP
    • /ko/docs/Glossary/RTSP does not exist but fell back to /en-US/docs/Glossary/RTSP
    • /ko/docs/Glossary/RTP does not exist but fell back to /en-US/docs/Glossary/RTP
    • /ko/docs/Glossary/RTP does not exist but fell back to /en-US/docs/Glossary/RTP
    • and 12 more flaws omitted
  • image_widths:
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 30 more flaws omitted

URL: /ko/docs/Web/Media/Autoplay_guide
Title: 미디어 및 Web Audio API 자동 재생 가이드
Flaw count: 17

  • macros:
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • This macro has been deprecated, and should be removed.
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • /ko/docs/Web/API/HTMLMediaElement/onplay does not exist
    • and 9 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/SVG/Attribute/d
Title: d
Flaw count: 8

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 2 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 11 possible)

URL: /ko/docs/Web/SVG/Element/a
Title: <a>
Flaw count: 33

  • macros:
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • This macro is deprecated; see https://github.com/orgs/mdn/discussions/347 to learn how to replace it.
    • and 17 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /docs/Web/HTML/Link_types
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 6 more flaws omitted

URL: /ko/docs/Web/Security
Title: 웹 보안
Flaw count: 50

  • macros:
    • /ko/docs/Glossary/XSS does not exist but fell back to /en-US/docs/Glossary/Cross-site_scripting
    • /ko/docs/Glossary/digital_certificate does not exist but fell back to /en-US/docs/Glossary/Digital_certificate
    • /ko/docs/Glossary/Signature/Security does not exist but fell back to /en-US/docs/Glossary/Signature/Security
    • /ko/docs/Glossary/Clickjacking does not exist but fell back to /en-US/docs/Glossary/Clickjacking
    • /ko/docs/Glossary/Clickjacking does not exist but fell back to /en-US/docs/Glossary/Clickjacking
    • and 33 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 7 more flaws omitted

URL: /ko/docs/WebAssembly/Loading_and_running
Title: Loading and running WebAssembly code
Flaw count: 20

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /ko/docs/Web/API/ArrayBuffer does not exist
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • and 13 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiate#Second_overload_example

URL: /ko/docs/WebAssembly/Concepts
Title: 웹어셈블리의 컨셉
Flaw count: 7

  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly
    • Can't resolve /ko/docs/MDN/Doc_status/API/WebWorkers
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/WebAssembly/C_to_wasm
    • and 2 more flaws omitted

URL: /ko/docs/WebAssembly/Understanding_the_text_format
Title: Understanding WebAssembly text format
Flaw count: 17

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /ko/docs/Web/API/ArrayBuffer does not exist
    • and 2 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/WebAssembly/Text_format_to_wasm
    • Can't resolve /ko/docs/WebAssembly/Text_format_to_wasm
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 5 more flaws omitted

URL: /ko/docs/WebAssembly/Exported_functions
Title: Exported WebAssembly functions
Flaw count: 7

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase
External URLs (3)

URL: /ko/docs/Web/JavaScript/Reference/Statements/for...in
Title: for...in

URL: /ko/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Title: 구조 분해 할당

(comment last updated: 2023-07-30 16:17:14)

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

hochan222
hochan222 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2023
@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2023
github-actions[bot]
github-actions bot reviewed Jul 30, 2023
View reviewed changes
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
files/ko/web/progressive_web_apps/guides/making_pwas_installable/index.md Outdated Show resolved Hide resolved
hochan222
hochan222 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check PR Files changed. LGTM :)

@hochan222 hochan222 merged commit e7dead4 into main Jul 30, 2023
10 checks passed
@hochan222 hochan222 deleted the ko/localized-links/4 branch July 30, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hochan222 hochan222 hochan222 approved these changes

@swimjiy swimjiy Awaiting requested review from swimjiy swimjiy is a code owner automatically assigned from mdn/yari-content-ko

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @hochan222